Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve meter check #1246

Merged
merged 2 commits into from
Nov 16, 2023
Merged

improve meter check #1246

merged 2 commits into from
Nov 16, 2023

Conversation

LKuemmel
Copy link
Contributor

@LKuemmel LKuemmel commented Nov 9, 2023

No description provided.

@LKuemmel LKuemmel requested a review from benderl November 9, 2023 13:36
benderl
benderl approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@benderl benderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde optional die Variablen meter_check und evse_check anders benennen, da so nicht wirklich ersichtlich ist, was True/False bedeutet.
meter_check-> meter_check_passed
evse_check -> evse_check_passed

@LKuemmel LKuemmel merged commit 04d8c5c into openWB:master Nov 16, 2023
1 check passed
@LKuemmel LKuemmel deleted the hardware_check branch November 16, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benderl benderl benderl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LKuemmel @benderl