Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Shelly Pro3EM as inverter to shelly module #1422

Merged
merged 2 commits into from
Mar 26, 2024
Merged

add Shelly Pro3EM as inverter to shelly module #1422

merged 2 commits into from
Mar 26, 2024

Conversation

ndrsnhs
Copy link
Contributor

@ndrsnhs ndrsnhs commented Feb 14, 2024

benderl
benderl requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@benderl benderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das größte Problem bei diesem PR ist, dass "generation" und "app" in einer Variablen vermischt werden. Wenn es eine Shelly Generation "3" gibt, kommt es zwangsläufig zu Inkompatibilitäten, daher kann das so nicht übernommen werden.

packages/modules/devices/shelly/device.py Outdated Show resolved Hide resolved
packages/modules/devices/shelly/config.py Outdated Show resolved Hide resolved
packages/modules/devices/shelly/device.py Outdated Show resolved Hide resolved
@benderl benderl added enhancement New feature or request question Further information is requested labels Feb 15, 2024
@ndrsnhs ndrsnhs requested a review from benderl February 21, 2024 12:18
@benderl benderl removed the question Further information is requested label Feb 21, 2024
@benderl
Copy link
Contributor

benderl commented Feb 21, 2024

Sieht jetzt wesentlich übersichtlicher aus.
Danke für die Anpassung.

@benderl benderl added the ui depends on changes in ui repository label Feb 21, 2024
@benderl benderl added this to the 2.1.4 milestone Feb 21, 2024
@LKuemmel LKuemmel merged commit 0d86507 into openWB:master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benderl benderl benderl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ui depends on changes in ui repository
Projects
None yet
Milestone
2.1.4 Step 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndrsnhs @benderl @LKuemmel