unify modbus sleeps (currently used by solaredge and huawei) #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benderl
previously requested changes
Mar 1, 2024
packages/modules/common/modbus.py
Outdated
Comment on lines
50
to
59
| def __init__(self, | ||
| delegate: Union[ModbusSerialClient, ModbusTcpClient], | ||
| address: str, port: int = 502, | ||
| sleep_after_connect: Optional[int] = None, | ||
| sleep_before_reconnect: Optional[int] = None): | ||
| self.delegate = delegate | ||
| self.address = address | ||
| self.port = port | ||
| self.sleep_after_connect = sleep_after_connect or 0 | ||
| self.sleep_before_reconnect = sleep_before_reconnect or 0 |
There was a problem hiding this comment.
Warum erst mit None initialisieren, um dann später darauf zu prüfen und 0 zu setzen?
Suggested change
| def __init__(self, | |
| delegate: Union[ModbusSerialClient, ModbusTcpClient], | |
| address: str, port: int = 502, | |
| sleep_after_connect: Optional[int] = None, | |
| sleep_before_reconnect: Optional[int] = None): | |
| self.delegate = delegate | |
| self.address = address | |
| self.port = port | |
| self.sleep_after_connect = sleep_after_connect or 0 | |
| self.sleep_before_reconnect = sleep_before_reconnect or 0 | |
| def __init__(self, | |
| delegate: Union[ModbusSerialClient, ModbusTcpClient], | |
| address: str, port: int = 502, | |
| sleep_after_connect: Optional[int] = 0, | |
| sleep_before_reconnect: Optional[int] = 0): | |
| self.delegate = delegate | |
| self.address = address | |
| self.port = port | |
| self.sleep_after_connect = sleep_after_connect | |
| self.sleep_before_reconnect = sleep_before_reconnect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.