Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarthome temperatur sensoren #1580

Merged
merged 6 commits into from
Apr 25, 2024
Merged

smarthome temperatur sensoren #1580

merged 6 commits into from
Apr 25, 2024

Conversation

okaegi
Copy link
Contributor

@okaegi okaegi commented Apr 21, 2024

Nur für openwb 2.0 übernehmen
Neu werden temperaturtopics (TemperatureSensor0/1/2) explizit im mqtt geschlöscht wenn nicht mehr gebraucht. Das vereinfacht das daily log im Json

Nur für openwb 2.0 übernehmen
Neu werden temperaturtopics  (TemperatureSensor0/1/2) explizit im mqtt geschlöscht wenn nicht mehr gebraucht. Das vereinfacht das daily log im Json
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
Copy link
Contributor

@benderl benderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich denke auch, dass Any hier keinen Sinn macht und auch für das Typechecking keine Vorteile bringt. Dann lieber komplett weg lassen.
Ein paar andere Typen habe ich als Vorschlag ergänzt.

packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
packages/smarthome/smartcommon.py Outdated Show resolved Hide resolved
@okaegi okaegi requested a review from benderl April 25, 2024 10:48
fix whitespace
@benderl benderl merged commit be06a38 into openWB:master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants