Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVCC SoC: detect and fix invalid cached vehicle #1673

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

MartinRinas
Copy link
Contributor

@MartinRinas MartinRinas commented Jun 15, 2024

re-create vehicle if stored vehicleID is no longer valid.


Summary of Changes

  • Added gRPC Retry Mechanism:

    • Introduced gRPCRetryTime and gRPCRetryCount constants to handle retry logic.
    • Added gRPCRetryResponse to specify the retry response message.
    • Added gRPCVehicleNoLongerValid to handle cases where the vehicle is no longer available.
  • New Function:

    • Implemented write_vehicle_id_mqtt function to write vehicle IDs to MQTT topics.

This summary highlights the key changes made in the PR, including the addition of new constants for gRPC retry logic and the implementation of a new function.

@MartinRinas MartinRinas changed the title detect and fix invalid cached vehicle EVCC SoC: detect and fix invalid cached vehicle Jun 15, 2024
@MartinRinas
Copy link
Contributor Author

@LKuemmel können wir hierfür ein temporären branch erstellen? Das würde es betroffenen Anwendern erlauben das ganze mal zu testen. Konnte bisher niemanden mit dem Problem und SSH Zugang finden um den Patch zu validieren. Der Fehler tritt erst nach einer Weile (1-2Wochen) auf, daher fällt es eher schwer das vor dem merge sinnvoll zu testen.

@LKuemmel
Copy link
Contributor

Bitte einen neuen PR für den Merge in den Feature-Branch erstellen.

@MartinRinas MartinRinas marked this pull request as ready for review July 5, 2024 14:16
@MartinRinas
Copy link
Contributor Author

@LKuemmel , der Featurebranch mit diesen Änderungen lief eine Zeit lang unauffällig, wir können diesen PR nun gern mergen und den Featurebranch wieder entfernen.

@LKuemmel LKuemmel merged commit 46dfeb4 into openWB:master Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants