SOC Modul über SkodaConnect #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
requested changes
Feb 7, 2023
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
LKuemmel
requested changes
Feb 16, 2023
Comment on lines
+48
to
+54
| def _is_optional_of_dict(requested_type): | ||
| # Optional[dict] is an alias for Union[dict, None] | ||
| if typing.get_origin(requested_type) == Union: | ||
| args = typing.get_args(requested_type) | ||
| if len(args) == 2: | ||
| return issubclass(args[0], dict) and issubclass(args[1], type(None)) | ||
| return False |
There was a problem hiding this comment.
Nach der Anmerkung von Lutz kann das nun weg oder?
Suggested change
| def _is_optional_of_dict(requested_type): | |
| # Optional[dict] is an alias for Union[dict, None] | |
| if typing.get_origin(requested_type) == Union: | |
| args = typing.get_args(requested_type) | |
| if len(args) == 2: | |
| return issubclass(args[0], dict) and issubclass(args[1], type(None)) | |
| return False |
There was a problem hiding this comment.
Nein, hier ist etwas anderes gemeint. In der Konfiguration werden Refresh-Tokens gespeichert, soweit sie verfügbar ist. Damit diese Tokens wieder wieder gepasst werden können, ist diese Anpassung nötig.
Ich habe mal zum Verständnis einen Test hinzugefügt.
vuffiraa72
force-pushed
the
soc-skodaconnect
branch
from
28718b5
to
ab0f9c4
Compare
LKuemmel
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Das SOC Modul nutzt die Bibliothek Skoda Connect.
Getestet habe ich mir meinem Skoda Enyaq, aber auch andere BEVs des Hersteller werden durch die Bibliothek unterstützt.
Im Dataclass_util wurde das Handling für Optional[dict] ergänzt, um in der SOC Modulkonfiguration optionale dict-Parameter zu ermöglichen.