Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fasm: patch ignored runtime dependency warnings #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jleightcap
Copy link
Contributor

@jleightcap jleightcap commented Oct 7, 2023

see:
ngi-nix/ngipkgs#7 (comment)

fasm provides two options for runtime parsing: textx and ANTLR4.

ANTLR4 is:

  • not immediately in nixpkgs as a C++ runtime with compatible CMake
    hooks
  • not easily exposed in the fasm build scripts.

There is an Arch Linux specific workaround on an unmerged branch.

For the time being, fall back to the flower textx parser and patch out
the runtime warning:

RuntimeWarning: Unable to import fast Antlr4 parser implementation.
      ImportError: cannot import name tags

      Falling back to the much slower pure Python textX based parser
      implementation.

      Getting the faster antlr parser can normally be done by installing the
      required dependencies and then reinstalling the fasm package with:
        pip uninstall
        pip install -v fasm

      warn(

Thanks for the tip @fricklerhandwerk!

Signed-off-by: Jack Leightcap jack@leightcap.com

see:
ngi-nix/ngipkgs#7 (comment)

fasm provides two options for runtime parsing: `textx` and ANTLR4.

ANTLR4 is:

- not immediately in nixpkgs as a C++ runtime with compatible CMake
  hooks
- not easily exposed in the fasm build scripts.

There is an Arch Linux specific workaround on an unmerged branch.

For the time being, fall back to the flower `textx` parser and patch out
the runtime warning:

```
RuntimeWarning: Unable to import fast Antlr4 parser implementation.
      ImportError: cannot import name tags

      Falling back to the much slower pure Python textX based parser
      implementation.

      Getting the faster antlr parser can normally be done by installing the
      required dependencies and then reinstalling the fasm package with:
        pip uninstall
        pip install -v fasm

      warn(
```

Thanks for the tip fricklerhandwerk!

Signed-off-by: Jack Leightcap <jack@leightcap.com>
@jleightcap jleightcap mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant