Coverage/reseller and nobroker role #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There looks to be one error:
Customer is expected - even when brokerRole is ResellerBroker - at C2 |
|
Works locally against openactive/openactive-test-suite#293 (however having issues with CI, so not merged) |
nickevansuk
requested changes
Feb 4, 2021
| // Throw error on incomplete customer details if C2, P or B | ||
| if (stage != FlowStage.C1 && (order.Customer == null || string.IsNullOrWhiteSpace(order.Customer.Email))) | ||
| { | ||
| // Unless it's B when the Broker isn't a ResellerBroker |
There was a problem hiding this comment.
Suggested change
| // Unless it's B when the Broker isn't a ResellerBroker | |
| // Unless it's B, P or C2 when the Broker isn't a ResellerBroker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for reseller and nobroker role.
I split it up in 2 commits (moving 2 ifs and extending for new checks)
Closes #72