Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"maximumAttendeeCapacity" and "remainingAttendeeCapacity" not on SessionSeries #281

Closed
nickevansuk opened this issue Oct 1, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@nickevansuk
Copy link
Contributor

nickevansuk commented Oct 1, 2018

"maximumAttendeeCapacity" and "remainingAttendeeCapacity" should not be recommended on SessionSeries as they do not make sense there under any circumstances. If they are included at SessionSeries level, an error should be presented to request they are moved to the ScheduledSession.

screen shot 2018-10-01 at 01 28 33

Test data 1:

{
  "@context": "https://openactive.io/",
  "type": "SessionSeries",
  "id": "https://example.com/events/452",
  "name": "Speedball",
  "description": "Speedball",
  "activity": [
    {
      "type": "Concept",
      "id": "https://openactive.io/activity-list/#2a41c553-84be-4970-b3d0-42f9ef6bd9a4",
      "prefLabel": "Road Cycling",
      "inScheme": "https://openactive.io/activity-list"
    }
  ],
  "offers": [
    {
      "type": "Offer",
      "id": "https://example.com/events/452#/offers/878",
      "validThrough": "2018-10-29T11:00:00Z",
      "validFrom": "2018-10-01T11:00:00Z",
      "description": "Winger space for Speedball.",
      "name": "Speedball winger position",
      "price": 10,
      "priceCurrency": "GBP",
      "isCancellable": true,
      "cancellationValidUntil": "2018-10-28T11:00:00Z"
    }
  ],
  "duration": "PT1H",
  "organizer": {
    "type": "Organization",
    "name": "Central Speedball Association",
    "url": "http://www.speedball-world.com",
    "termsOfService": {
      "type": "TermsOfService",
      "url": "url"
    }
  },
  "location": {},
  "subEvent": [
    {
      "type": "ScheduledSession",
      "identifier": 123,
      "id": "https://example.com/events/452/subEvents/132",
      "eventStatus": "https://schema.org/EventScheduled",
      "maximumAttendeeCapacity": 30,
      "remainingAttendeeCapacity": 20,
      "startDate": "2018-10-30T11:00:00Z",
      "endDate": "2018-10-30T12:00:00Z",
      "duration": "PT1H"
    }
  ]
}

Test data 2 (inverted):

{
  "@context": "https://openactive.io/",
  "type": "ScheduledSession",
  "identifier": 123,
  "id": "https://example.com/events/452/subEvents/132",
  "eventStatus": "https://schema.org/EventScheduled",
  "maximumAttendeeCapacity": 30,
  "remainingAttendeeCapacity": 20,
  "startDate": "2018-10-30T11:00:00Z",
  "endDate": "2018-10-30T12:00:00Z",
  "duration": "PT1H",
  "superEvent": {
    "type": "SessionSeries",
    "id": "https://example.com/events/452",
    "name": "Speedball",
    "description": "Speedball",
    "activity": [
      {
        "type": "Concept",
        "id": "https://openactive.io/activity-list/#2a41c553-84be-4970-b3d0-42f9ef6bd9a4",
        "prefLabel": "Road Cycling",
        "inScheme": "https://openactive.io/activity-list"
      }
    ],
    "offers": [
      {
        "type": "Offer",
        "id": "https://example.com/events/452#/offers/878",
        "validThrough": "2018-10-29T11:00:00Z",
        "validFrom": "2018-10-01T11:00:00Z",
        "description": "Winger space for Speedball.",
        "name": "Speedball winger position",
        "price": 10,
        "priceCurrency": "GBP",
        "isCancellable": true,
        "cancellationValidUntil": "2018-10-28T11:00:00Z"
      }
    ],
    "duration": "PT1H",
    "organizer": {
      "type": "Organization",
      "name": "Central Speedball Association",
      "url": "http://www.speedball-world.com",
      "termsOfService": {
        "type": "TermsOfService",
        "url": "url"
      }
    },
    "location": {}
  }
}
@nickevansuk nickevansuk added the bug Something isn't working label Oct 1, 2018
@nickevansuk nickevansuk added this to To do in Data Validator v0.1 via automation Oct 1, 2018
@petewalker
Copy link
Contributor

This is not reflected in https://www.openactive.io/modelling-opportunity-data/EditorsDraft/ - this needs to be fixed there first.

@petewalker petewalker moved this from To do to Backlog in Data Validator v0.1 Oct 1, 2018
nickevansuk added a commit to openactive/data-models that referenced this issue Oct 1, 2018
@nickevansuk
Copy link
Contributor Author

Ok so have raised:

If you're happy with the latter I'll go ahead and merge?

@petewalker petewalker moved this from Backlog to In progress in Data Validator v0.1 Oct 1, 2018
Data Validator v0.1 automation moved this from In progress to Done Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants