Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing details in the PostalAddress #125

Closed
nickevansuk opened this issue Jun 6, 2018 · 2 comments
Closed

Missing details in the PostalAddress #125

nickevansuk opened this issue Jun 6, 2018 · 2 comments

Comments

@nickevansuk
Copy link
Contributor

nickevansuk commented Jun 6, 2018

Applying rules:

Not like this:

    "location": {
      "type": "Location",
      "name": "Driffield School",
      "address": {
        "type": "PostalAddress",
        "addressRegion": "Humberside",
        "postalCode": "YO25 5HR"
      },
      "geo": {
        "type": "GeoCoordinates",
        "latitude": 54.010134,
        "longitude": -0.425882
      }
    },

"Humberside, YO25 5HR" will result in the event not being listed in Google Reserve, as fields are missing

Google Reserve requires streetAddress, addressLocality, addressRegion, postalCode and addressCountry to all be provided.

@daniel-somersault
Copy link
Collaborator

@nickevansuk EN will need to work through the venues on the system. We have recently implemented an address lookup so they will be able to populate this data easily now. I have updated that specific example though for you to check.

@nickevansuk
Copy link
Contributor Author

Great, thanks @daniel-somersault. I note addressCountry is missing from the example data you updated, though that's covered in #119. The than that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants