feat: Docker with package upgrades #553
Conversation
| - name: Build and push Docker image for OpenActive Test Suite | ||
| uses: docker/build-push-action@v4 | ||
| with: | ||
| context: . | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
This needs to be expanded to test before push (https://docs.docker.com/build/ci/github-actions/test-before-push/), to ensure that everything works as expected.
The reference implementation service (https://github.com/openactive/OpenActive.Server.NET/blob/d6e2f57dd8b6a7835cf8bcd747eef7553a7128f4/.github/workflows/docker-test.yaml#L16-L32) can be added here to facilitate this.
The config can also be passed in (https://github.com/openactive/OpenActive.Server.NET/blob/d6e2f57dd8b6a7835cf8bcd747eef7553a7128f4/.github/workflows/docker-test.yaml#L53-L56)
Though note that we'd need to get ghcr.io/openactive/reference.bookingsystem.identity running to actually test Puppeteer (which requires figuring out how to get it running on HTTP, perhaps by overriding the "urls" property in appsettings.json via an env var as per dotnet/AspNetCore.Docs#25626 (comment))
Also note that the two use the same fake database and there may be assumptions tied to this running on the same machine (as it writes to the same location on local disk), therefore something like this may be more appropriate https://github.com/openactive/OpenActive.Server.NET/blob/d6e2f57dd8b6a7835cf8bcd747eef7553a7128f4/.github/workflows/docker-test-2.yaml#L18-L38
No description provided.