Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the right-to-left (RTL) #303

Closed
1 of 2 tasks
fontgah opened this issue Mar 15, 2023 · 4 comments
Closed
1 of 2 tasks

add the right-to-left (RTL) #303

fontgah opened this issue Mar 15, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@fontgah
Copy link

fontgah commented Mar 15, 2023

Search before asking

  • issues 中没有找到类似的内容。
    I searched in the issues and found nothing similar.

feature

add the right-to-left (RTL) feature for Persian and Arabic translations to display

描述 Motivation

Hello, thank you for providing us with such an amazing extension and program for free. Please add the right-to-left (RTL) feature for Persian and Arabic translations to display the text correctly.

Solution

No response

还有其他内容吗?Anything else?

No response

你是否愿意提交一份 PR?Are you willing to submit a PR?

  • 我愿意提供 PR! I'm willing to submit a PR!
@fontgah fontgah added the enhancement New feature or request label Mar 15, 2023
@OverflowCat
Copy link
Contributor

Do you mean the incorrect position of the cursor in the translation result area when translating from an RTL page to an LTR language and vice versa, from an LTR page to an RTL language?

image
image

@fontgah
Copy link
Author

fontgah commented Mar 15, 2023

Yes, by default, the Farsi translation content is on the left side, which is not readable
It should be fixed

https://chrome.google.com/webstore/detail/rtl-fixer/mkeclhaiiffmeeokkomoameekkpiiecf

https://imgur.com/a/58JxZSA

https://lh3.googleusercontent.com/OT1j7Vtci6Pop86cnGD1CqeS2PPZC4ToRdYW1CSSRvfw5QsW88z-OAp-QbqpjhtWnFOkWNzFlLXVUDcLhfYg-LqlMEU=w640-h400-e365-rj-sc0x00ffffff

like this

سلام، ممنون از اینکه چنین افزونه و برنامه شگفت انگیزی را به صورت رایگان در اختیار ما قرار دادید. لطفاً ویژگی راست به چپ (RTL) را برای ترجمه فارسی و عربی اضافه کنید تا متن به درستی نمایش داده شود.

It will be great if you add the ability to select a display font from the list of fonts installed on Windows

OverflowCat added a commit to OverflowCat/openai-translator that referenced this issue Mar 15, 2023
@OverflowCat
Copy link
Contributor

OverflowCat commented Mar 15, 2023

@fontgah Hi, does the implementation of #317 look good to you? (screenshots attached in it)

@yetone yetone closed this as completed in 7393fc4 Mar 15, 2023
@fontgah
Copy link
Author

fontgah commented Mar 16, 2023

@fontgah Hi, does the implementation of #317 look good to you? (screenshots attached in it)

Thank you very much for adding this feature. It has a bug, though. It doesn’t translate some texts and the system gives this message: “Translation could not interpret the text. Please provide a clear and translatable text.”

For example, please translate this text.

https://github.com/yetone/openai-translator/releases/tag/v0.0.25

fix: contextMenus error in firefox extension (#312)

feat: update userscripts

fix: trim selected word

fix: style pollution

feat: add clearHotkey (#316)

feat: update userscripts

fix: popupcard container overflow hidden

feat: update userscripts

fix: eslint

feat: support RTL text (resolves #303) (#317)

feat: add Azure OpenAI service support (#178)
Untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants