Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstring correction #2067

Closed
lubiluk opened this issue Oct 14, 2020 · 2 comments
Closed

Docstring correction #2067

lubiluk opened this issue Oct 14, 2020 · 2 comments
Labels
help wanted

Comments

@lubiluk
Copy link
Contributor

lubiluk commented Oct 14, 2020

Hi, I think in the line below it should say ob['desired_goal'] rather than ob['goal']:

gym/gym/core.py

Line 196 in 38a1f63

assert reward == env.compute_reward(ob['achieved_goal'], ob['goal'], info)

@jkterry1
Copy link
Collaborator

Please submit a PR for this :)

@lubiluk lubiluk mentioned this issue Sep 1, 2021
Merged
@lubiluk
Copy link
Contributor Author

lubiluk commented Sep 1, 2021

There :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lubiluk @jkterry1