Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add license classifier to PyPI package #826

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

RobPasMue
Copy link
Contributor

@RobPasMue RobPasMue commented Nov 15, 2023

Having the license classifier in PyPI is also important so that it is uploaded as part of the package's metadata. Otherwise, when querying it to PyPI this information is not shown in the package's metadata.

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Additional context & links

Having the license classifier in PyPI is also important so that it is uplaoded as part of the package's metadata. Otherwise, when querying it to PyPI this information is not shown in the package's metadata.
@RobPasMue RobPasMue requested a review from a team as a code owner November 15, 2023 14:34
@RobPasMue RobPasMue mentioned this pull request Nov 15, 2023
1 task
@rattrayalex
Copy link
Collaborator

Thanks @RobPasMue , this looks reasonable to me. It may take a bit to merge since we'll need to update our codegen to reflect.

@schnerd
Copy link
Collaborator

schnerd commented Nov 16, 2023

(Approving but will defer to you on when to merge Alex)

@RobertCraigie RobertCraigie changed the base branch from main to next November 21, 2023 19:25
@RobertCraigie
Copy link
Collaborator

Thanks!

@RobertCraigie RobertCraigie merged commit 0332b65 into openai:next Nov 21, 2023
1 check passed
stainless-bot pushed a commit that referenced this pull request Nov 21, 2023
Having the license classifier in PyPI is also important so that it is uplaoded as part of the package's metadata. Otherwise, when querying it to PyPI this information is not shown in the package's metadata.
@stainless-bot stainless-bot mentioned this pull request Nov 21, 2023
stainless-bot pushed a commit that referenced this pull request Nov 22, 2023
Having the license classifier in PyPI is also important so that it is uplaoded as part of the package's metadata. Otherwise, when querying it to PyPI this information is not shown in the package's metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants