Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test script failed in FetchPush-v1 and HandManipulatePen-v0 #12

Closed
marianophielipp opened this issue Nov 9, 2018 · 3 comments
Closed

Comments

@marianophielipp
Copy link

python -m spinup.run ppo --hid [32,32] --env FetchPush-v1 --exp_name installtestFetchPushv0
python -m spinup.run ppo --hid [32,32] --env HandManipulatePen-v0 --exp_name installtestFetchPushv0

'Traceback (most recent call last):
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/utils/run_entrypoint.py", line 11, in
thunk()
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/utils/run_utils.py", line 162, in thunk_plus
thunk(**kwargs)
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/algos/ppo/ppo.py", line 183, in ppo
x_ph, a_ph = core.placeholders_from_spaces(env.observation_space, env.action_space)
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/algos/ppo/core.py", line 27, in placeholders_from_spaces
return [placeholder_from_space(space) for space in args]
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/algos/ppo/core.py", line 27, in
return [placeholder_from_space(space) for space in args]
File "/Users/mjphieli/Documents/dataScience/opait/spinningup/spinup/algos/ppo/core.py", line 24, in placeholder_from_space
raise NotImplementedError
NotImplementedError'

@jachiam
Copy link
Contributor

jachiam commented Nov 9, 2018

Hi @marianophielipp. Spinning Up implementations currently only support envs with Box observation spaces (where observations are real-valued vectors). These environments have Dict observation spaces, so each obs is a dict of (key, vector) pairs. If you want to test things out in these envs, I recommend doing it as a hacking project! :)

You may find that these envs are particularly challenging for PPO---you may want to look into using DDPG, and then reimplementing Hindsight Experience Replay.

@jachiam jachiam closed this as completed Nov 9, 2018
@machinaut
Copy link

Additionally gym wrappers are a way we change environments in a generic way.

There is an environment wrapper for flattening dict observation spaces here, which is maybe useful as a starting point

https://github.com/openai/gym/blob/master/gym/wrappers/dict.py#L8

@marianophielipp
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants