Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend][backend] Add mulhi lowering to amd backend #3563

Merged
merged 14 commits into from
Apr 5, 2024
Merged

[frontend][backend] Add mulhi lowering to amd backend #3563

merged 14 commits into from
Apr 5, 2024

Conversation

zahimoud
Copy link
Contributor

@zahimoud zahimoud commented Apr 4, 2024 •
edited
Loading

  • Adds mulhi to amd lowering to llvm using libdevice call.
  • Adds unit test for umulhi32
  • Moves amd/nvidia MulhiUIOpConversion to common lib

@zhanglx13 zhanglx13 mentioned this pull request Apr 4, 2024
Closed
@zahimoud zahimoud force-pushed the zahi/mulhi branch 3 times, most recently from 3d07a10 to 52f005b Compare April 4, 2024 20:23
@zahimoud zahimoud marked this pull request as ready for review April 5, 2024 17:32
@zahimoud zahimoud requested a review from ptillet as a code owner April 5, 2024 17:32
@zahimoud zahimoud changed the title [frontend][backend] Add mulhi to amd libdevice and lowering [frontend][backend] Add mulhi lowering to amd backend Apr 5, 2024
ThomasRaoux
ThomasRaoux approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zahimoud zahimoud merged commit 64b4ed7 into main Apr 5, 2024
5 checks passed
@zahimoud zahimoud deleted the zahi/mulhi branch April 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelszczerbuk pawelszczerbuk pawelszczerbuk left review comments

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zahimoud @ThomasRaoux @pawelszczerbuk