Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable concurrent builds to reduce memory usage #1345

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

mpol
Copy link
Contributor

@mpol mpol commented Apr 25, 2022

As described in the issue #1343 builds get killed by the OOM killer
sometimes.

Add disableConcurrentBuilds to the build options to reduce
memory usage whem multiple builds are triggered.

@mpol mpol requested a review from marekhorst April 25, 2022 11:56
As described in the issue #1343 builds get killed by the OOM killer
sometimes.

Add lock('iis-build') to the build options to reduce
memory usage whem multiple builds are triggered.
As described eg. in https://issues.jenkins.io/browse/JENKINS-35359
the disableConcurrentBuilds option can only prevent concurrent builds
of a single branch and using locks is the recommended workaround
for serializing all the builds in a multibranch pipeline.
@mpol mpol force-pushed the mpol_disable_concurrent_builds branch from c62add1 to 33869d0 Compare April 25, 2022 12:21
@mpol
Copy link
Contributor Author

mpol commented Apr 25, 2022

Change the approach from disableConcurrentBuilds to lock.

As described eg. in https://issues.jenkins.io/browse/JENKINS-35359
the disableConcurrentBuilds option can only prevent concurrent builds
of a single branch and using locks is the recommended workaround
for serializing all the builds in a multibranch pipeline.

Copy link
Member

@marekhorst marekhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mpol mpol merged commit 33869d0 into master Apr 25, 2022
@mpol mpol deleted the mpol_disable_concurrent_builds branch April 25, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants