Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ForgeRock Maven repositories #36

Assignees

Comments

@tsujiguchitky
Copy link
Contributor

Description

OpenAM relies on closed ForgeRock Maven repositories. In the current situation, Maven caches are required for building OpenAM.

Solution

Do the following items for OpenAM and dependent libraries(OpenDJ,ForgeRock Commons,etc..).

  • Remove ForgeRock repository tags in pom.xml
  • Change Maven groupId
  • Adjust maven dependency
@ogis-miyamura
Copy link
Contributor

Thank you for committing the wonderful codes.
I got success to build 12 repositories well.

I noticed the following points:

  1. openam-jp/forgerock-ui

    • It seems that bzip2 package is required.
    • In my opinion, along with the version specs of JDK and Maven, it is kindness to note necessary packages together.
  2. openam-jp/opendj-sdk

    • Unit test failed in my build environment.

      Failed tests: 
        UtilsTestCase.testCannotWriteOnNewFile:69 expected [false] but found [true]
      
      Tests run: 43, Failures: 1, Errors: 0, Skipped: 0
      
    • Adding the -DskipTests option, build succeeded.

I will continue to check the codes.

@tsujiguchitky
Copy link
Contributor Author

Thank you for review.

  1. openam-jp/forgerock-ui

Sorry, I did not notice it. I think It is difficult to cover the required package because it varies depending on OS. I will describe the version of JDK and Maven in future pull requests.

  1. openam-jp/opendj-sdk

Umm I have not seen that. Sorry to inconvenience you but please register the issue with opendj-sdk project.

@ogis-miyamura
Copy link
Contributor

  1. openam-jp/forgerock-ui
    I think It is difficult to cover the required package because it varies depending on OS.

That is true, I realize how apparent it really is.

I will describe the version of JDK and Maven in future pull requests.

It might be a good time for us to rewrite openam-jp/openam/README.md to more useful content.

  1. openam-jp/opendj-sdk

Umm I have not seen that. Sorry to inconvenience you but please register the issue with opendj-sdk project.

Thank you for the information.
I will try again in other build environment.
if all else fails, I'll register the issue.

@ogis-miyamura
Copy link
Contributor

In my opinion, along with the version specs of JDK and Maven, it is kindness to note necessary packages together.

I'm sorry I didn't explain it enough.
What I want to say was 'along with the version specs on https://github.com/openam-jp/openam#build-the-source-code of JDK and Maven ...'.

@tsujiguchitky
Copy link
Contributor Author

What I want to say was 'along with the version specs on https://github.com/openam-jp/openam#build-the-source-code of JDK and Maven ...'.

I had a misunderstanding...
Certainly it is better to add it to the README.md.

OGIS-RyoKobayashi pushed a commit that referenced this issue Mar 29, 2019
* Delete dependency of ForgeRock maven repositories

* Change groupId

* Update ForgeRock Commons version

* Skip maven-pmd-plugin

* Change External dependency

* Fix copying license text

* Add properties files for ESAPI

* Add Restlet Repository

* Move Oracle Repository

* External JavaScript dependency resolution

* OPENAM-9559, OPENAM-9188 fix radius server checkstyle errors & remove unused text file

* Update THIRD-PARTY.properties

* Update qrcode-generator to 1.4.3

* Revert the plugin name of jquery-sortable("nestingSortable" -> "sortable")

* Change bootstrap-clockpicker version

* Remove handlebars 3.0.3

* remove xalan/xerces dependency

* Override ESAPI dependency to avoid class duplication

* Update THIRD-PARTY.properties
OGIS-RyoKobayashi added a commit to OGIS-RyoKobayashi/openam that referenced this issue May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment