Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.0 client should support client_secret_basic #44

Closed
tsujiguchitky opened this issue Apr 8, 2019 · 0 comments
Closed

OAuth 2.0 client should support client_secret_basic #44

tsujiguchitky opened this issue Apr 8, 2019 · 0 comments
Assignees
Milestone

Comments

@tsujiguchitky
Copy link
Contributor

Description

When OpenAM works as OAuth 2.0 Client, client authentication to token endpoint is done by client_secret_post.

However, according to RFC 6979 section 2.3.1, it seems that client_secret_basic should be used rather than client_secret_post.

Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes).

Solution

Add an option to use client_secret_basic as client authentication in OAuth 2.0 authentication module.

@tsujiguchitky tsujiguchitky added this to the OpenAM 14.0.0 milestone May 31, 2019
oss-aimoto added a commit that referenced this issue Aug 15, 2019
* OAuth2.0/OIDC authentication module support client_secret_basic
OGIS-RyoKobayashi pushed a commit that referenced this issue Oct 25, 2019
* Issue #44 OAuth 2.0 client should support client_secret_basic

* OAuth2.0/OIDC authentication module support client_secret_basic

* Remove unnecessary getTokenServicePOSTparametersForBasic()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants