Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting an instance of the authentication module registered by default also deletes the authentication modules of the same type #50

Closed
tsujiguchitky opened this issue Apr 11, 2019 · 0 comments
Closed

Deleting an instance of the authentication module registered by default also deletes the authentication modules of the same type #50

tsujiguchitky opened this issue Apr 11, 2019 · 0 comments
Assignees
@ksuzukiTVDn1
Milestone
OpenAM 14.0.0

Comments

@tsujiguchitky
Copy link
Contributor

Description

After initial configuration, some authentication modules are registered by default (DataStore, Federation, HOTP, LDAP, etc).
If you create another instance of these modules and then delete the default instance, the instance you created will be deleted.

Steps to reproduce

  1. Create a new HOTP module instance
  2. Delete default HOTP module instance

Expected Results

Only default instance is deleted.

Actual Results

All instances of HOTP are deleted.

References

This issue is related to OPENAM-9156.

[OPENAM-9156] 'Not Found' error in UI when opening a custom auth module created with ssoadm with the name the same as type
@tsujiguchitky tsujiguchitky added this to the OpenAM 14.0.0 milestone May 31, 2019
@ksuzukiTVDn1 ksuzukiTVDn1 self-assigned this Jul 22, 2019
ogis-miyamura pushed a commit that referenced this issue Aug 28, 2019
@ksuzukiTVDn1 @ogis-miyamura
Issue #50 Deleting an instance of the authentication module registere…
a72c14b 
…d by default also deletes the authentication modules of the same type (#100)

* Change to subConfig check first. and not remove all of tree if default module have subConfig

* add copyright to source code header

* wrong year in copyright
ogis-miyamura pushed a commit that referenced this issue Sep 3, 2019
@ksuzukiTVDn1 @ogis-miyamura
Issue #50 part of OpenAM-9156 Deleting an instance of the authenticat…
18621ef 
…ion module registered by default also deletes the authentication modules of the same type (#112)

* skip check in target module in static AUTO_CREATED_AUTHENTICATION_MODULES map

* keep AUTO_CREATED_AUTHENTICATION_MODULES map
@ogis-miyamura ogis-miyamura mentioned this issue Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksuzukiTVDn1 ksuzukiTVDn1

Labels
None yet
Projects
None yet
Milestone
OpenAM 14.0.0
Development

No branches or pull requests
3 participants
@tsujiguchitky @ogis-miyamura @ksuzukiTVDn1