Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Perform docker pull if image not on host #82

Closed
SudoBrendan opened this issue Aug 24, 2018 · 3 comments
Closed

[Feature Request] Perform docker pull if image not on host #82

SudoBrendan opened this issue Aug 24, 2018 · 3 comments
Milestone

Comments

@SudoBrendan
Copy link

Greetings,

I'm noticing many users (including myself) being confused by a quirk of ShinyProxy: if an image doesn't exist on the docker host, ShinyProxy refuses to boot it. This issue isn't reported here, but rather, on the configuration examples provided by your example repo:

openanalytics/shinyproxy-config-examples#4
openanalytics/shinyproxy-config-examples#2

This missing feature is non-obvious to newcomers, and makes the shinyproxy docker container unable to stand on it's own (it requires that it's host contain more than docker, namely, all the docker images it serves). Is there an obvious reason this requirement exists, or could docker pull be invoked if an image isn't found on the host? This missing feature makes deploying shinyproxy on docker orchestrators difficult, where admins shouldn't have to care about host requirements, and where automated janitors might sweep away "unused" images shinyproxy relies on, breaking the site.

giocomai added a commit to giocomai/shinyproxy-config-examples that referenced this issue Nov 7, 2018
To users trying out the example files it may not be immediately obvious that the Docker image must be available on the host, and the error message is very generic. This seems to be an issue with other users that test ShinyProxy, see also: openanalytics/shinyproxy#82
@baswanders
Copy link

+100. It took me a long time to understand this.
It would be great if it could pull the images.

@robsonyeg
Copy link
Contributor

Any roadmap to have this feature?

@LEDfan
Copy link
Member

LEDfan commented Mar 9, 2023

This has been implemented as part of ShinyProxy 3.0.0, see: https://shinyproxy.io/documentation/configuration/#docker-image-pull-policy

@LEDfan LEDfan closed this as completed Mar 9, 2023
@LEDfan LEDfan added this to the Next milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants