Issue 91 #116
Open
Issue 91 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial ShinyProxySpecMainProvider was able to load Add settings from application.yml. The new version will delegate the loading task to ShinyProxySpecMainProvider and ShinyProxySpecExternalProvider ShinyProxyspecMainProvider does the same then the initial ShinyProxySpecMainProvider, ie. it loads settings from application.yml. ShinyProxySpecExternalProvider will try to load files from a specific path. This path can be set in applicaton.yml using the new proxy.specs-external-path attribute. The attribute used in the individual settings files are quite the same (using camel case) : - id, displayName, description, containerCmd, logoUrl, accessGroups, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(settings): App configuration in individual files (issue 91)
The initial ShinyProxySpecMainProvider was able to load App settings from application.yml.
The new version will delegate the loading task to ShinyProxySpecMainProvider and ShinyProxySpecExternalProvider
ShinyProxyspecMainProvider does the same then the initial ShinyProxySpecMainProvider, ie. it loads settings from application.yml.
ShinyProxySpecExternalProvider will try to load files from a specific path. This path can be set in application.yml using the new proxy.specs-external-path attribute.
The attribute used in the individual settings files are quite the same (using camel case) :
- id, displayName, description, containerCmd, logoUrl, accessGroups, ...