Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when ZIP ROm package does not have META-INF/com/android/metadata #394

Closed
freechelmi opened this issue Dec 18, 2023 · 2 comments · Fixed by #399
Closed

Improve error message when ZIP ROm package does not have META-INF/com/android/metadata #394

freechelmi opened this issue Dec 18, 2023 · 2 comments · Fixed by #399
Assignees
@tsterbak
Labels
enhancement New feature or request
Milestone
Release Beta-Vers...

Comments

@freechelmi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I tried to flash a TWRP flashable ZIP containing a stock rom ( https://bit.ly/4ar1VWU)
that does not have a META-INF/com/android/metadata

Describe the solution you'd like
either change the criteria for image_works_with_device() function
or display a complete error message explaining why the ZIp file is not accepted

Describe alternatives you've considered
A clear message in RED saying " This zip file is rejected because XXXXX "

Additional context
Add any other context or screenshots about the feature request here.
@freechelmi freechelmi added the enhancement New feature or request label Dec 18, 2023
@tsterbak tsterbak self-assigned this Dec 21, 2023
@tsterbak
Copy link
Member

Thats a really good point! I will look into it :)

@tsterbak tsterbak mentioned this issue Dec 24, 2023
Merged
@tsterbak tsterbak linked a pull request Dec 25, 2023 that will close this issue
Improve error message for loading images #399
Merged
tsterbak added a commit that referenced this issue Jan 14, 2024
@tsterbak
Improve error message for loading images (#399)
bf01053 
This PR mainly addresses #394 and #354.

It also adds:
- improved Makefile
@tsterbak tsterbak mentioned this issue Jan 14, 2024
Merged
@tsterbak
Copy link
Member

Should be resolved with the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsterbak tsterbak

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release Beta-Version 0.5.2 - New Year...
2 participants
@freechelmi @tsterbak