Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config formatting #130

Merged
merged 15 commits into from
Apr 23, 2023
Merged

Config formatting #130

merged 15 commits into from
Apr 23, 2023

Conversation

MagicLike
Copy link
Member

I reformatted the configs for more consistency, removed an unneeded reboot instructions for the FPs and added the TWRP image to every config. (It needs to be updated - outdated version)

@MagicLike
Reformatted configs
1f68603
@MagicLike
More formatting
373e616
@MagicLike
Removed unneeded rebooting instructuons from FPs
11df3ae
@MagicLike
Added TWRP image to every config
c7f998b
@MagicLike
Updated the config section
b100366 
- Made "metadata" & "requirements"
- Reorderd metadata steps
- Removed a unneeded statement as it is already written in the requirements section
- Added notice to please retain the given order of fields
@tsterbak tsterbak self-requested a review March 27, 2023 18:05
@MagicLike
Copy link
Member Author

Any updates on this @tsterbak? Will this get merged before the 0.4.3 Release?

@tsterbak
Copy link
Member

I want to go through the changes in the config and check them.
But it will be merged for 0.4.3-beta, which will be probably delayed to next week since there is no hurry now because so far there are no substantial bugs (as far as I can tell)

@tsterbak tsterbak added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 14, 2023
@tsterbak tsterbak added this to the Release Beta 0.4.3 milestone Apr 14, 2023
@MagicLike
Copy link
Member Author

I want to go through the changes in the config and check them. But it will be merged for 0.4.3-beta, which will be probably delayed to next week since there is no hurry now because so far there are no substantial bugs (as far as I can tell)

Alright, I will also check Samsung configs - I found one typo so far ^^

tsterbak
tsterbak reviewed Apr 15, 2023
View reviewed changes
README.md Show resolved Hide resolved
@tsterbak
Copy link
Member

This looks very good and cleans up the structure of the config files.

As soon as the duplicated command line for fajita is removed, this can be merged :)

@MagicLike
Copy link
Member Author

This looks very good and cleans up the structure of the config files.

As soon as the duplicated command line for fajita is removed, this can be merged :)

Done! Everything should be ready for merge! 😃

tsterbak
tsterbak approved these changes Apr 23, 2023
View reviewed changes
openandroidinstaller/assets/configs/fajita.yaml Show resolved Hide resolved
README.md Show resolved Hide resolved
@tsterbak tsterbak merged commit e3291c9 into openandroidinstaller-dev:dev Apr 23, 2023
@MagicLike MagicLike deleted the config-formatting branch April 23, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsterbak tsterbak tsterbak approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Release Beta 0.4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MagicLike @tsterbak