Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the addons installer progress bars and fix issues #139

Merged
merged 4 commits into from
May 6, 2023

Conversation

tsterbak
Copy link
Member

@tsterbak tsterbak commented Apr 11, 2023

This PR adds:

Todo:

  • can the device interaction and waiting time be optimized?

@tsterbak tsterbak added this to the Release Beta 0.4.3 milestone Apr 11, 2023
@tsterbak tsterbak added bug Something isn't working enhancement New feature or request labels Apr 11, 2023
@tsterbak tsterbak self-assigned this Apr 11, 2023
@tsterbak
Copy link
Member Author

@MagicLike If you have time, feel free to test this :)

@MagicLike
Copy link
Member

MagicLike commented Apr 11, 2023

Will do! :D

@MagicLike
Copy link
Member

@MagicLike If you have time, feel free to test this :)

Ok, I am encountering a weird issue: My OPO gets stuck in the TWRP booting sequence and isn't reachable via CLI anymore...
I will reflash the complete stock firmware and see if that resolves the issue...

@tsterbak
Copy link
Member Author

Ok, I am encountering a weird issue: My OPO gets stuck in the TWRP booting sequence and isn't reachable via CLI anymore...
I will reflash the complete stock firmware and see if that resolves the issue...

Hm, thats weird. 🤔 is there something odd in the logs?

@MagicLike
Copy link
Member

Ok, I am encountering a weird issue: My OPO gets stuck in the TWRP booting sequence and isn't reachable via CLI anymore...
I will reflash the complete stock firmware and see if that resolves the issue...

Hm, thats weird. thinking is there something odd in the logs?

Nope, nothing... Seems to be related to the device's firmware...

@MagicLike
Copy link
Member

I retried it with the stock firmware and it works perfectly fine... 🤔

@MagicLike
Copy link
Member

MagicLike commented Apr 11, 2023

@tsterbak Ok: the second progress bar for the addons is now gone, but the adb issues remain as you already stated in here: #124 (comment).

Maybe it would be better to remove the bar(s) entirely to stop confusion about it until it is maybe fixed someday?

@tsterbak tsterbak merged commit 540df59 into dev May 6, 2023
@tsterbak tsterbak deleted the improve-addons-progress-bar branch May 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants