Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions update #197

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Conversation

MagicLike
Copy link
Member

@MagicLike MagicLike commented Jul 30, 2023

As seen in the warnings of GitHub Actions after running the latest ci build, it needs an update.
grafik

TODO:

  • Update checkout
  • Update setup-python
  • Update automatic-releases
  • Update Python version(?)

See my latest test build here: https://github.com/MagicLike/openandroidinstaller/actions/runs/5685471674
grafik

@MagicLike
Copy link
Member Author

@tsterbak I noticed, that OAI currently depends on Python 3.9 and does not allow 3.11. (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/requirements.txt) Should it even be considered to update to 3.11?

@tsterbak
Copy link
Member

@tsterbak I noticed, that OAI currently depends on Python 3.9 and does not allow 3.11. (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/requirements.txt) Should it even be considered to update to 3.11?

Thanks for the upgrade! 😊
The better source for requirements is the pyproject.toml, since I use poetry to manage the project: https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/pyproject.toml
I would like to upgrade directly to 3.11 in the future, but right now some libraries lack compatibility as far as I can tell. So I would stay on 3.9 for now, since its still active and we don't need any features only available in newer versions (afaik).

@MagicLike
Copy link
Member Author

I would like to upgrade directly to 3.11 in the future, but right now some libraries lack compatibility as far as I can tell. So I would stay on 3.9 for now, since its still active and we don't need any features only available in newer versions (afaik).

If so - this PR is ready to ship! 🎉

@MagicLike MagicLike marked this pull request as ready for review July 30, 2023 16:34
@tsterbak tsterbak added the enhancement New feature or request label Jul 30, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.4.5 milestone Jul 30, 2023
@@ -86,7 +86,7 @@ jobs:
- name: Display structure of downloaded files
run: ls -R
- name: Create release
uses: marvinpinto/action-automatic-releases@latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change? Does it do the same thing?

Copy link
Member Author

@MagicLike MagicLike Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a fork of the project of marvinpinto with multiple patches, such as switching to node 16. (GitHub Action complains about the use of node 12 as it will no longer be supported at some point)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only "problem" I had was the error seen in my second screenshot - maybe I can also resolve it, but afaik it depends on how you release a new version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it should do essentially the same - docs can be found here: https://github.com/dciborow/action-github-releases#supported-parameters

@MagicLike MagicLike changed the base branch from main to dev July 30, 2023 16:51
@MagicLike
Copy link
Member Author

Now I get a different error message :D
grafik

@MagicLike
Copy link
Member Author

@tsterbak Maybe you can try it on your end - Some how GitHub Actions is unable to access the releases of my fork...

Run with debug log: https://github.com/MagicLike/openandroidinstaller/actions/runs/5707419025/job/15465878236#step:11:213

@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

@tsterbak Maybe you can try it on your end - Some how GitHub Actions is unable to access the releases of my fork...

Yeah, this makes sense, your repo cannot create releases on the openandroidinstaller repo. I will just merge it and if necessary fix it at the time of the next release :) but it looks good! Thanks a lot! :)

@tsterbak tsterbak merged commit e963043 into openandroidinstaller-dev:dev Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants