-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions update #197
Actions update #197
Conversation
Switched to fork, which includes latest patches, until the main project is patched
This reverts commit af662da.
@tsterbak I noticed, that OAI currently depends on Python 3.9 and does not allow 3.11. (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/requirements.txt) Should it even be considered to update to 3.11? |
Thanks for the upgrade! 😊 |
If so - this PR is ready to ship! 🎉 |
@@ -86,7 +86,7 @@ jobs: | |||
- name: Display structure of downloaded files | |||
run: ls -R | |||
- name: Create release | |||
uses: marvinpinto/action-automatic-releases@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this change? Does it do the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a fork of the project of marvinpinto with multiple patches, such as switching to node 16. (GitHub Action complains about the use of node 12 as it will no longer be supported at some point)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only "problem" I had was the error seen in my second screenshot - maybe I can also resolve it, but afaik it depends on how you release a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it should do essentially the same - docs can be found here: https://github.com/dciborow/action-github-releases#supported-parameters
@tsterbak Maybe you can try it on your end - Some how GitHub Actions is unable to access the releases of my fork... Run with debug log: https://github.com/MagicLike/openandroidinstaller/actions/runs/5707419025/job/15465878236#step:11:213 |
Yeah, this makes sense, your repo cannot create releases on the openandroidinstaller repo. I will just merge it and if necessary fix it at the time of the next release :) but it looks good! Thanks a lot! :) |
As seen in the warnings of GitHub Actions after running the latest ci build, it needs an update.
TODO:
Update Python version(?)See my latest test build here: https://github.com/MagicLike/openandroidinstaller/actions/runs/5685471674