Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device-support-request.md #236

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

anon1892
Copy link
Member

@anon1892 anon1892 commented Aug 4, 2023

Make simple fields about device, so even beginner fills it up correctly

Make simple fields about device, so even beginner fills it up correctly
@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

Great idea!

One little question. Most people requesting devices right now, are (supposedly) coming over the "request support for the device" button in the installer, so they should know the device code. The device code is even inserted in the title of the issue directly: https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/openandroidinstaller/views/start_view.py#L275C1-L275C215
Would that change the description of the issue?
If not, I'm fine to merge it 🙂

@anon1892
Copy link
Member Author

anon1892 commented Aug 4, 2023

Yes, I was aware of this.
Like that (asking for code name), it's ready for all cases (request button, or not)
The aim is to have some informations without having to search for the codename on XDA... (for example, I only look at Xiaomi/Poco devices)

I just added model field for specific phones, like Samsung, with their Exynos / Snapdragon versions...

@tsterbak tsterbak merged commit b9cd508 into openandroidinstaller-dev:main Aug 4, 2023
@anon1892 anon1892 deleted the anon1892-patch-1 branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants