Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked the device request template as form #243

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

MagicLike
Copy link
Member

No description provided.

@tsterbak tsterbak changed the base branch from main to dev August 6, 2023 17:25
@tsterbak tsterbak added the enhancement New feature or request label Aug 6, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.4.5 milestone Aug 6, 2023
@tsterbak
Copy link
Member

tsterbak commented Aug 6, 2023

Hey, thank you for building this! 🙂

It can only be merged with the next release of the Installer, since the issue template URL is part of the source code (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/openandroidinstaller/views/start_view.py#L275).

Can you update the URL and make sure, that the new template works with the new URL?

@MagicLike
Copy link
Member Author

Hey, thank you for building this! 🙂

It can only be merged with the next release of the Installer, since the issue template URL is part of the source code (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/main/openandroidinstaller/views/start_view.py#L275).

Can you update the URL and make sure, that the new template works with the new URL?

Oh yeah totally forgot about that one - either I can test that tonight or tomorrow afternoon! 👍

@MagicLike
Copy link
Member Author

MagicLike commented Aug 7, 2023

@tsterbak Updated the URL and tested it, should work just fine 👍

@tsterbak tsterbak merged commit 2af8e34 into openandroidinstaller-dev:dev Aug 8, 2023
@MagicLike
Copy link
Member Author

@tsterbak should I add the "`" to the device code variable in the issue link, that the device code gets formatted like this?
grafik

@tsterbak
Copy link
Member

should I add the "`" to the device code variable in the issue link, that the device code gets formatted like this?

Yeah, that looks neat! :)

@MagicLike
Copy link
Member Author

should I add the "`" to the device code variable in the issue link, that the device code gets formatted like this?

Yeah, that looks neat! :)

Done! 0bc2f9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants