add Oneplus3 support #365
Merged
add Oneplus3 support #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #362 merged first to avoid conflicts |
tsterbak
reviewed
Nov 22, 2023
tsterbak
added
device
SirRGB
force-pushed
the
oneplus3
branch
2 times, most recently
from
3824d43
to
b2597ae
Compare
* taken from gsmarena, wikipedia and the lineage wiki
* taken from the lineage wiki and https://telegra.ph/G5-Variants--Code-Names-10-07 Signed-off-by: SirRGB <sirrgb@proton.me>
* asserts taken from https://github.com/LineageOS/android_device_oneplus_oneplus3/blob/e975bda0561217fae2a342c2e8c1848b3e3cf370/BoardConfig.mk#L35C29-L35C66 * copied config from cheeseburger Signed-off-by: SirRGB <sirrgb@proton.me>
|
Is this ready to be merged? Looks good to me :) |
As stated, #362 needs to merge first.., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#273