Flip animation doesn't work sometime when flinging backword #17

Closed
openaphid opened this Issue Dec 7, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@openaphid
Owner

openaphid commented Dec 7, 2012

Please refer to the original report: #2 (comment)

@openaphid

This comment has been minimized.

Show comment
Hide comment
@openaphid

openaphid Dec 8, 2012

Owner

The issue seems be fixed to me with the new update in develop branch

Owner

openaphid commented Dec 8, 2012

The issue seems be fixed to me with the new update in develop branch

@iPaulPro

This comment has been minimized.

Show comment
Hide comment
@iPaulPro

iPaulPro Dec 8, 2012

@openaphid Unfortunately, I was just able to reproduce this on the develop branch APK. If you flip down a few times, then up a few, and keep repeating, you may see it. It appears to be related to the timing of the touch event (relative to the animation).

iPaulPro commented Dec 8, 2012

@openaphid Unfortunately, I was just able to reproduce this on the develop branch APK. If you flip down a few times, then up a few, and keep repeating, you may see it. It appears to be related to the timing of the touch event (relative to the animation).

@openaphid

This comment has been minimized.

Show comment
Hide comment
@openaphid

openaphid Dec 8, 2012

Owner

@iPaulPro Thanks. I'll re-check it today

Owner

openaphid commented Dec 8, 2012

@iPaulPro Thanks. I'll re-check it today

@openaphid

This comment has been minimized.

Show comment
Hide comment
@openaphid

openaphid Dec 8, 2012

Owner

@iPaulPro I can easily reproduce it in landscape mode. I'm working on a fix for it.

Owner

openaphid commented Dec 8, 2012

@iPaulPro I can easily reproduce it in landscape mode. I'm working on a fix for it.

@openaphid

This comment has been minimized.

Show comment
Hide comment
@openaphid

openaphid Dec 8, 2012

Owner

The issue occurs in some edge conditions. I tweaked the code a little bit to rule it out. Please try the latest APK in develop branch.

I must admit that the logic in FlipCards is messy since I added bouncing support. It becomes tricky to handle states and actions between UI thread and GL thread. Maybe we should rewrite it in a future version.

Owner

openaphid commented Dec 8, 2012

The issue occurs in some edge conditions. I tweaked the code a little bit to rule it out. Please try the latest APK in develop branch.

I must admit that the logic in FlipCards is messy since I added bouncing support. It becomes tricky to handle states and actions between UI thread and GL thread. Maybe we should rewrite it in a future version.

@iPaulPro

This comment has been minimized.

Show comment
Hide comment
@iPaulPro

iPaulPro Dec 8, 2012

I am no longer able to reproduce this bug, on the latest dev APK. Good stuff!

iPaulPro commented Dec 8, 2012

I am no longer able to reproduce this bug, on the latest dev APK. Good stuff!

@openaphid openaphid closed this Dec 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment