Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 code reduction w/ shared_imports #168

Merged
merged 10 commits into from
May 9, 2023
Merged

v3 code reduction w/ shared_imports #168

merged 10 commits into from
May 9, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented May 9, 2023

  • reduces amount of generated code by adding shared import modules that are * imported into files that need them

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title v3 import reduction v3 code reduction w/ shared_imports May 9, 2023
@spacether spacether merged commit 8d65f59 into 3_0_0 May 9, 2023
@spacether spacether deleted the v3_import_reduction branch May 9, 2023 23:39
spacether added a commit that referenced this pull request May 17, 2023
* Adds typing_imports

* Adds typing_imports for header and parameter

* Updates request body imports

* Adds response_imports

* Adds schema_imports

* Adds security_scheme_imports

* Adds server imports

* Adds operation_imports

* typing_imports -> header_imports

* Sample regen
@spacether spacether added this to the 3.0.0 milestone May 17, 2023
spacether added a commit that referenced this pull request May 31, 2023
* Adds typing_imports

* Adds typing_imports for header and parameter

* Updates request body imports

* Adds response_imports

* Adds schema_imports

* Adds security_scheme_imports

* Adds server imports

* Adds operation_imports

* typing_imports -> header_imports

* Sample regen
spacether added a commit that referenced this pull request Jun 8, 2023
* Adds typing_imports

* Adds typing_imports for header and parameter

* Updates request body imports

* Adds response_imports

* Adds schema_imports

* Adds security_scheme_imports

* Adds server imports

* Adds operation_imports

* typing_imports -> header_imports

* Sample regen
spacether added a commit that referenced this pull request Aug 16, 2023
* Adds typing_imports

* Adds typing_imports for header and parameter

* Updates request body imports

* Adds response_imports

* Adds schema_imports

* Adds security_scheme_imports

* Adds server imports

* Adds operation_imports

* typing_imports -> header_imports

* Sample regen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant