v3 adds enum literal input and output type hints #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
spacether
added a commit
that referenced
this pull request
Aug 16, 2023
* Fixes java warnings * Adds exception throw if enum values types are not allowed * Adds and uses enumInfo * Adds typeToValues enumInfo * Addsstring literal output for single schema validate with enums * Adds validate method writing for simple schema classes with enums * Adds string and int enum type hints to return type of validate * Adds string literal output type for single type, per literal input string * Removes are type in validate for enum classes of type int, str, bool * Fixes overload signatures for int/bool/str with enums * Adds bol and int enum to object output properties * object properties of type string with enum now have literal output types * Adds _helper_validate_str_overload template * Uses string overload template for multiple types * Adds and uses bool overload template * Adds and uses int validate overload template * Handles int enum value for number use case, java tests fixed, samples regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 adds enum literal input and output type hints
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*.For Windows users, please run the script in Git BASH.