Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 3.1.0 const feature #210

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Adds 3.1.0 const feature #210

merged 18 commits into from
Aug 22, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Aug 21, 2023

  • writes out class that stores const values
  • writes schema class data store that stores const value to name
  • adds and uses SequenceNotStr to fix overload type checking for sequences that are not str or bytes

When working on this PR I found a bug in swagger-parser on parsing boolean + integer const values. I filed it here:
swagger-api/swagger-parser#1966

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether added the 3.1.0 spec feature 3.1.0 spec feature label Aug 21, 2023
@spacether spacether linked an issue Aug 21, 2023 that may be closed by this pull request
@spacether spacether changed the title Adds const feature Adds 3.1.0 const feature Aug 21, 2023
@spacether spacether marked this pull request as draft August 21, 2023 20:09
@spacether spacether marked this pull request as ready for review August 22, 2023 22:45
@spacether spacether merged commit 8318ab9 into master Aug 22, 2023
3 checks passed
@spacether spacether deleted the feat_adds_const branch August 22, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.0 spec feature 3.1.0 spec feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add const feature
1 participant