Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds python 3.9 CI testing, fixes bug #227

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Aug 29, 2023

Adds python 3.9 CI testing

  • removes envlist from the tox file so it can use the available python that the environment has, this was needed to get py39 working
  • fixes a bug where python 3.9 was not working because the immutabledict class had an issue with the immutabledict base class and the Generic class

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Adds python 3.9 CI testing Adds python 3.9 CI testing, fixes bug Aug 29, 2023
@spacether spacether merged commit 9b1c56f into master Aug 30, 2023
4 checks passed
@spacether spacether deleted the feat_adds_py39_tests branch August 30, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a consistent method resolution order (MRO) for bases Generic, immutabledict
1 participant