Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds openapi 3.1.0 if/then/else json schema features + fixes exclusiveMax/Min bug #234

Merged
merged 17 commits into from
Nov 1, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Sep 2, 2023

  • Adds openapi 3.1.0 if/then/else json schema features
  • Python generator documentation updated to show that those keywords are now supported
  • Tests added to the 3.1.0 unit test client from the json schema test suite
  • fixed a bug with 3.1.0 code generation where exclusiveMaximum + exclusiveMinimum data was not being accessed and stored correctly

Note:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft September 15, 2023 01:04
@spacether spacether changed the title Adds openapi 3.1.0 if and then json schema features Adds openapi 3.1.0 if/then/else json schema features Oct 31, 2023
This was linked to issues Oct 31, 2023
@spacether spacether self-assigned this Oct 31, 2023
@spacether spacether changed the title Adds openapi 3.1.0 if/then/else json schema features Adds openapi 3.1.0 if/then/else json schema features + fixes exclusiveMax/Min bug Nov 1, 2023
@spacether spacether marked this pull request as ready for review November 1, 2023 00:46
@spacether spacether merged commit a05acd8 into master Nov 1, 2023
4 checks passed
@spacether spacether deleted the feat_adds_if branch November 1, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant