Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java 20 test failure #247

Merged
merged 13 commits into from
Oct 4, 2023
Merged

Fix java 20 test failure #247

merged 13 commits into from
Oct 4, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 2, 2023

  • Fixes the test that is breaking in java 20 but not earlier java versions

Verification:

  • this tests is passing locally with java 20
  • I was unable to get a CI config working that included java 20 + maven

Note: this may fix building for java 20: #242

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Oct 2, 2023 that may be closed by this pull request
6 tasks
@spacether spacether changed the title Fix java21 test failure Fix java20 test failure Oct 2, 2023
@spacether spacether changed the title Fix java20 test failure Fix java test failure Oct 4, 2023
@spacether spacether removed a link to an issue Oct 4, 2023
6 tasks
@spacether spacether merged commit 0624f33 into master Oct 4, 2023
4 checks passed
@spacether spacether deleted the feat_fix_java21_test_failure branch October 4, 2023 20:59
@spacether spacether changed the title Fix java test failure Fix java 20 test failure Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant