Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators, adjusts storage of exclusiveMaximum/exclusiveMinimum [breaking] #316

Merged
merged 15 commits into from
Dec 5, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 4, 2023

Generators, adjusts storage of CodegenSchema exclusiveMaximum/exclusiveMinimum

  • changes maximum/minimum types from String to BigDecimal to be consistent with openapi 3.1.0 types
  • changes exclusiveMaximum/exclusiveMinimum types from Boolean to BigDecimal to be consistent with openapi 3.1.0 types
  • also adds org.codehaus.janino dependency back in because it is needed for conditions in the logging config
  • adds java tests of schema processing for exclusiveMin/Maximum for 3.0.0/30.03/3.1.0 documents
  • python schema class generation improved with isSImpleX helper methods that were developed and used in java templates

Breaking Change with Fallback

  • this is a breaking change with fallback for templates that used maximum/minimum/exclusiveMaximum/exclusiveMinimum
  • if one depended on the old variables, one can adjust your template logic using the new values. What was {{#if exclusiveMaximum}} would now need {{#neq exclusiveMaximum null}}

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft December 4, 2023 09:24
@spacether spacether force-pushed the feat_updates_schema_exclusive_props branch from 82e6763 to d1d0568 Compare December 4, 2023 21:34
@spacether spacether changed the title Generators, adjusts storage of maximum/minimum/exclusiveMaximum,exclusiveMinimum Generators, adjusts storage of exclusiveMaximum/exclusiveMinimum Dec 5, 2023
@spacether spacether marked this pull request as ready for review December 5, 2023 02:18
@spacether spacether merged commit d41a95e into master Dec 5, 2023
5 checks passed
@spacether spacether deleted the feat_updates_schema_exclusive_props branch December 5, 2023 02:24
@spacether spacether changed the title Generators, adjusts storage of exclusiveMaximum/exclusiveMinimum Generators, adjusts storage of exclusiveMaximum/exclusiveMinimum [breaking] Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant