Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java, updates JsonSchema + List/MapSchemaValidator validate methods #343

Merged
merged 27 commits into from
Dec 24, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 24, 2023

Java, updates JsonSchema + List/MapSchemaValidator validate methods
These methods are being adjusted to accept almost any input data to pave the way for

  • future ingestion of json data whee it is a list of any data or a map of any data

Updates

  • adds general validate methods to all schemas which accepts and returns @Nullable Object
  • uses new validate method to run the failing test cases where invalidly typed input arguments are passed
  • schema docs updated to show new validate method signature

Note: Strictly typed ingestion will be done with the future list and map builder classes

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Java, enables the list/map validator validate methods Java, updated List/MapSchemaValidator validate methods Dec 24, 2023
@spacether spacether changed the title Java, updated List/MapSchemaValidator validate methods Java, updated JsonSchema + List/MapSchemaValidator validate methods Dec 24, 2023
@spacether spacether changed the title Java, updated JsonSchema + List/MapSchemaValidator validate methods Java, updates JsonSchema + List/MapSchemaValidator validate methods Dec 24, 2023
@spacether spacether merged commit 82a62d9 into master Dec 24, 2023
5 checks passed
@spacether spacether deleted the feat_java_add_listmap_val_methods_to_intf branch December 24, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant