Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java, refactoring to simplify schema validate #370

Merged
merged 21 commits into from
Jan 20, 2024

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 19, 2024

Java, refactoring to simplify schema validate

  • json schema validator classes now implement one method only, abstract single method interface
  • eliminates redundant storage of the validator data in the validator; that data is now accessed from the ingested schema instance

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether merged commit 73aa768 into master Jan 20, 2024
5 checks passed
@spacether spacether deleted the java_refactors_validate_input branch January 20, 2024 05:07
@spacether spacether added the java Pull requests that update Java code label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant