Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java client, adds RequestBody #390

Merged
merged 40 commits into from
Feb 16, 2024
Merged

Java client, adds RequestBody #390

merged 40 commits into from
Feb 16, 2024

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Feb 10, 2024

Java client, adds RequestBody

  • request body supports application/json and text/plain content type serialization
  • request bodies use sealed classes because there can be multiple pairs of contentType, validatedSchemaPayload that are accepted
  • Sealed validated payload output classes added to schemas to describe the validatedSchemaPayload that request bodies need
  • tests added of json and plain text request body serialization

Future Work

  • add bytes and file handling
  • add "application/x-www-form-urlencoded"
  • add multipart/form

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Feb 16, 2024 that may be closed by this pull request
@spacether spacether added the java Pull requests that update Java code label Feb 16, 2024
@spacether spacether changed the title Java, adds RequestBody Java client, adds RequestBody Feb 16, 2024
@spacether spacether merged commit 45240af into master Feb 16, 2024
5 checks passed
@spacether spacether deleted the java_adds_requestBody_pt2 branch February 16, 2024 22:30
@spacether spacether mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java client, add requestBody feature
1 participant