Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java generator: adds gradle build tool support #430

Merged
merged 17 commits into from
May 2, 2024
Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Apr 30, 2024

  • Adds buildTool cli option for java with the options: gradle/maven (default maven)
    • buildTool is an additionalProperty passed in to the generate command
  • Gradle wrapper files are gitignored
  • Some small java fixes to satisfy the Java checker checks
  • Java readmes updated to show grade/maven instructions
  • Java petstore sample switched to using gradle

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/generate_samples_configs/python*
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft April 30, 2024 23:52
@spacether spacether changed the title Adds buildTool cli option for java Adds gradble build tool support for java generator May 1, 2024
@spacether spacether changed the title Adds gradble build tool support for java generator Adds gradle build tool support for java generator May 1, 2024
@spacether spacether marked this pull request as ready for review May 2, 2024 18:39
@spacether spacether merged commit 9e824ae into master May 2, 2024
5 checks passed
@spacether spacether deleted the java_adds_gradle branch May 2, 2024 18:40
@spacether spacether changed the title Adds gradle build tool support for java generator Java generator: adds gradle build tool support May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant