-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributor can run tests for this project on Windows #32
Conversation
d437f37
to
def366d
Compare
567fc51
to
413ddc9
Compare
26f02a1
to
d0a7864
Compare
Migrating discussion from #30 (comment):
|
@GSDTN, would you mind posting the errors you got trying
I also get errors (on mac) if I try
(Though I did I can see if there's a way to fix that, but in any case I think we need to see your errors that are unique to windows :) |
I tried running the definedServerPath.test.js using mocha from the terminal and had a similar failure.
Those tests run within IntelliJ. So the error on satisfyApiSpec I was seeing is likely more my approach to running the test than the test itself.
How would you recommend running the satisfyApiSpec test. Or all tests globally.
|
I agree with this:
Re:
|
@GSDTN unless you have objections I will merge this since this change might benefit some Windows developers. Happy to extend this to work for you too if we figure out what goes wrong when you run |
As #30 (comment) shows, contributors on windows should be able to run this project.
I don't have a Windows machine but these changes allowed
npm run test:full
to succeed on a Windows 10 WM and also the Travis builds.Changes: