Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic of recursive scanning #21

Closed
langecode opened this issue Mar 4, 2019 · 1 comment
Closed

Semantic of recursive scanning #21

langecode opened this issue Mar 4, 2019 · 1 comment

Comments

@langecode
Copy link
Member

langecode commented Mar 4, 2019 •
edited

Your code currently does not check for "package." but rather "package" with a startsWith, so if I have two packages like
a.b.cde.SomeWS
and
a.b.cdefgh.SomeWS

you'll match both classes if I specify a.b.cde as package and recurse flag is specified. That's why my code had a startsWith(package+".") in the check...

Hope you fix it...

Originally posted by @sunnymoon in #20 (comment)
@langecode
Copy link
Member Author

I see your point!

However the current behaviour is exactly the same as the Swagger JAX-RS module provides in JaxrsAnnotationScanner.java

Furthermore isn't it a rare case where you actually would have two packages with the same prefix both containing JAX-RS endpoints where you would like to exclude one of those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@langecode