Ensure not required parameters are created as optional properties #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
approved these changes
Mar 30, 2023
…i-ts#1052) According to the OpenAPI 3.1.0 spec, a parameter is required if one of these matches: - it has 'in: "path"' - it has 'required: true' See spec at Parameter Object - Fixed Fields: https://spec.openapis.org/oas/v3.1.0#fixed-fields-9 Fixes openapi-ts#1052
AplusKminus
force-pushed
the
pr/1052-optional-parameters
branch
from
eac4e81
to
22eac11
Compare
|
Hi Drew, I rebased the branch and fixed the merge conflicts. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the missing dependency
viteand fixes #1052.Vitest requires vite to run. See the docs.
How to Review
The fix is in src/transform/components-object.ts, the rest is just test adjustments, updated snapshots and the added dependency.
Checklist
examples/directory updated (if applicable)