Fix missing parameters in operation object #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
commented
Apr 26, 2023
| ctx.operations[operationObject.operationId] = { | ||
| operationType, | ||
| comment: getSchemaObjectComment(operationObject, 1), | ||
| }; | ||
| output.push(indent(`${method}: operations[${escStr(operationObject.operationId)}];`, indentLv)); | ||
| } else { | ||
| // fold top-level PathItem parameters into method-level, with the latter overriding the former | ||
| const keyedParameters: Record<string, ParameterObject | ReferenceObject> = {}; |
There was a problem hiding this comment.
Just moves this up one level; that’s it!
drwpow
commented
Apr 26, 2023
| @@ -276,7 +276,7 @@ export interface RequestBodyObject extends Extensable { | |||
| */ | |||
| export interface MediaTypeObject extends Extensable { | |||
| /** The schema defining the content of the request, response, or parameter. */ | |||
| schema?: SchemaObject; | |||
| schema?: SchemaObject | ReferenceObject; | |||
There was a problem hiding this comment.
Irrelevant type bug that came up while writing the test
drwpow
commented
Apr 26, 2023
| _Code generation is hard!_ And for that reason, starting with a very clear expectation of your end-goal can make working easier. | ||
| Reasoning about code generation can be quite difficult until you “invert your thinking” and approach it output-first. Adopting TDD can turn very unclear/abstract problems into concrete ones with clear steps to resolution. | ||
|
|
||
| ✨ When starting any task, **write a failing test first!** ✨ |
There was a problem hiding this comment.
Tweaked wording of this to harp on how helpful TDD is when contributing.
I am not that smart. I need TDD to be able to do anything in this library :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1065. This was a dumb bug where we just didn’t do a complete parameter lookup if it had an
operationId🤦. Was as easy as moving a couple lines of code above theif()statement.How to Review
Captured in tests; tests should pass.
Checklist
examples/directory updated (if applicable)