Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BiomeJS for linting, formatting #1626

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Use BiomeJS for linting, formatting #1626

merged 1 commit into from
Apr 23, 2024

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Apr 23, 2024

Changes

Swaps ESLint and Prettier for Biome, a faster linter + formatter built for the JS ecosystem. I’ve been extremely happy with it on other projects, and it has better out-of-the-box default rulesets than ESLint, hands-down. Excited for a faster, easier-to-use tool for the JS ecosystem.

Prettier is still in deps, mostly because it is still needed for formatting .md and .yaml, but linting isn’t enforced there. Prettier used to used to check formatting in CI, and now it’s not thanks to Biome handling both. So Prettier is now a convenience when working in docs and nothing more.

How to Review

  • CI updated; CI should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: 078094a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-pages bot commented Apr 23, 2024

Deploying openapi-ts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 078094a
Status: ✅  Deploy successful!
Preview URL: https://12eff8e7.openapi-ts.pages.dev
Branch Preview URL: https://biomejs.openapi-ts.pages.dev

View logs

@drwpow drwpow merged commit 41cf263 into main Apr 23, 2024
7 of 8 checks passed
@drwpow drwpow deleted the biomejs branch April 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant