Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support corporate proxy based on standard http_proxy environment vari… #1698

Closed
wants to merge 2 commits into from

Conversation

Reggino
Copy link

@Reggino Reggino commented Jun 17, 2024

…able

Changes

This change will make the CLI command support an environment variable called http_proxy. This is a standard environment variable in environments where a http proxy is required to access the internet.

How to Review

Setup a http proxy server. Then start the openapi-typescript CLI command with an environment variable http_proxy. E.g.:

http_proxy=http://myproxy.company.lan:1234 ./node_modules/.bin/openapi-typescript 

Copy link

changeset-bot bot commented Jun 17, 2024

⚠️ No Changeset found

Latest commit: d11e4b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow
Copy link
Contributor

drwpow commented Jun 17, 2024

I’m in favor of this change, but could you add docs for this please? This feels like it’s worth a mention somewhere (anywhere is fine, but probably cli.md would be my recommendation)

@Reggino
Copy link
Author

Reggino commented Jun 18, 2024

Thanks, i've updated the documentation.

@drwpow drwpow changed the base branch from main to 6.x June 19, 2024 16:47
@drwpow drwpow changed the base branch from 6.x to main June 19, 2024 16:47
@drwpow
Copy link
Contributor

drwpow commented Jun 19, 2024

This looks great, but I think you meant to open the PR against the 6.x branch? Currently main is for the upcoming 7.x version that will be released soon, and it no longer relies on undici (just uses native Node fetch).

I tried changing the base branch, but it resulted in a pretty confused git history so I think you’ll have to rebase it against 6.x on your end. But with that change, happy to approve & merge (feel free to open another PR if it’s easier, too)

@Reggino Reggino closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants