Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default values being non-nullable; add --default-non-nullable flag #631

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jun 3, 2021

Reverts #613 due to feedback, and adds a --default-non-nullable flag to manually opt in to this behavior.

README updated with new docs

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #631 (c87280f) into main (a36a728) will increase coverage by 1.48%.
The diff coverage is 87.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   88.53%   90.02%   +1.48%     
==========================================
  Files           9       10       +1     
  Lines         349      391      +42     
  Branches      123      142      +19     
==========================================
+ Hits          309      352      +43     
- Misses         37       39       +2     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
src/transform/headers.ts 23.07% <0.00%> (-4.20%) ⬇️
src/transform/index.ts 87.93% <78.78%> (+8.30%) ⬆️
src/transform/responses.ts 84.21% <81.81%> (-3.89%) ⬇️
src/transform/paths.ts 92.00% <87.50%> (ø)
src/transform/request.ts 95.00% <95.00%> (ø)
src/transform/schema.ts 97.59% <95.23%> (+0.53%) ⬆️
src/transform/parameters.ts 98.00% <96.42%> (+0.50%) ⬆️
src/index.ts 80.00% <100.00%> (+7.27%) ⬆️
src/transform/operation.ts 100.00% <100.00%> (+3.12%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fb371...c87280f. Read the comment docs.

@drwpow drwpow merged commit 5ba7056 into main Jun 3, 2021
@drwpow drwpow deleted the revert-default-non-null branch June 3, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant