Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java/Microprofile] Add support for Jackson serialization & async #11554

Merged

Conversation

pravussum
Copy link
Contributor

@pravussum pravussum commented Feb 9, 2022

Add support for Jackson serialization & async interfaces using Mutiny in Java Microprofile library

This PR

  • adds support for a new library option "microprofileMutiny" to generate async signatures in the API interfaces using SmallRye Mutiny which is the reactive library used by Quarkus - this will wrap the return types in Uni<>
  • adds support for the Jackson JSON serialization in the Microprofile library - currently only JSONB is supported

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

/cc @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@pravussum pravussum force-pushed the java-microprofile-improvements branch from 8f8db75 to 3abefee Compare February 9, 2022 11:08
@pravussum pravussum changed the title WIP [Java/Microprofile] Add support for Jackson serialization & async [Java/Microprofile] Add support for Jackson serialization & async Feb 9, 2022
@wing328
Copy link
Member

wing328 commented Feb 14, 2022

@pravussum thanks for the PR. Can you please resolve the merge conflicts when merging the latest master into this PR?

@wing328 wing328 modified the milestones: 6.0.0, 6.0.1 May 26, 2022
@wing328 wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022
@melloware
Copy link

@pravussum does this also handle Multipart correctly for Jackson? See: #10618

@wing328 wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022
@wing328 wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022
@wing328 wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022
…erfaces using Mutiny in Java Microprofile library
@pravussum pravussum force-pushed the java-microprofile-improvements branch from 7983f0d to 4662309 Compare January 4, 2023 19:19
@pravussum
Copy link
Contributor Author

@pravussum does this also handle Multipart correctly for Jackson? See: #10618

There has been no work regarding Multipart in the context of this PR 🤷

@pravussum
Copy link
Contributor Author

@wing328 I adressed your comments and rebased on the current master.

@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@jekkel
Copy link
Contributor

jekkel commented Feb 3, 2023

@wing328 Hey there - any reason this for this not being merged?

@wing328
Copy link
Member

wing328 commented Feb 3, 2023

@jekkel have you tested the change locally?

I wasn't able to find time to run some tests and would appreciate if the community can help test it.

@jekkel
Copy link
Contributor

jekkel commented Feb 3, 2023

@jekkel have you tested the change locally?

I wasn't able to find time to run some tests and would appreciate if the community can help test it.

We're running the branch version for quite some time now without any issues.

@wing328
Copy link
Member

wing328 commented Feb 3, 2023

@jekkel that's good 👍

@wing328 wing328 merged commit 4f1708c into OpenAPITools:master Feb 3, 2023
@wing328
Copy link
Member

wing328 commented Feb 3, 2023

FYI. Merged #14614 to fix the code format

@jekkel
Copy link
Contributor

jekkel commented Feb 3, 2023

Thanks! I wonder whether this could be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants