Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower max override from 100 to 90 #92

Merged
merged 1 commit into from Mar 29, 2016
Merged

Conversation

CrushingT1D
Copy link
Contributor

Change from 100 to 90 as it is meant to be a minimum bound in case of user entry error. In this case a user (me) is trying to set it to 90 on purpose which is a reasonable value.

Change from 100 to 90 as it is meant to be a minimum bound in case of user entry error. In this case a user (me) is trying to set it to 90 on purpose which is a reasonable value.
@scottleibrand
Copy link
Contributor

I'm fine with this. At the time we set these limits, we thought there was some value to having a "range" instead of a single target. Since then we've been running with min_bg = max_bg, so I have no problem setting the max_bg = min_bg = 90 as a lower bound.

Does anyone see any reason not to merge this?

@danamlewis
Copy link
Contributor

I am also fine with this given what we've seen across the user base.

On Mon, Mar 28, 2016 at 2:11 PM, Scott Leibrand notifications@github.com
wrote:

I'm fine with this. At the time we set these limits, we thought there was
some value to having a "range" instead of a single target. Since then we've
been running with min_bg = max_bg, so I have no problem setting the max_bg
= min_bg = 90 as a lower bound.

Does anyone see any reason not to merge this?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#92 (comment)

Dana Lewis | http://diyps.org | @danamlewis
http://www.twitter.com/danamlewis | http://www.linkedin.com/in/danalewis
"Doing something for someone else is more important than anything you would
do for yourself."

@scottleibrand scottleibrand merged commit 74119d7 into openaps:dev Mar 29, 2016
@bewest bewest mentioned this pull request May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants